On 2010-12-15 17:37, Bruce Cran wrote: > On Wed, 15 Dec 2010 16:29:23 +0100 > Jens Axboe <jaxboe@xxxxxxxxxxxx> wrote: > >> Really blktrace_api.h should just go away, since it's an OS interface >> and should be exposed as such. We've traditionally always used __uxx >> types in those interfaces. You should not be picking that up on >> FreeBSD :-) > > It looks like blktrace_api.h is being parsed through the depend rule > in Makefile.[FreeBSD|NetBSD|mac] due to the headers being listed in > $(SOURCE) - gcc just ignores missing <> headers while clang generates an > error as it builds the dependency list. Since headers which are > included within source files will be listed as a dependency anyway, I > think they can be removed from $(SOURCE). This looks good, thanks! -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe fio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
