On 2010-06-11 06:33, YAMAMOTO Takashi wrote: > hi, > > please look at the following patch. > > YAMAMOTO Takashi > > Signed-off-by: YAMAMOTO Takashi <yamamoto@xxxxxxxxxxxxx> > > commit e7aa7a65700932fe68d96015c06e6e1b1ecea0da > Author: YAMAMOTO Takashi <yamamoto@xxxxxxxxxxxxx> > Date: Fri Jun 11 12:32:42 2010 +0900 > > fix a weird check of the return value of aio_cancel. > > i don't know what this 1 means in the first place but at least > it isn't portable. instead, check if the i/o has already > completed. (AIO_ALLDONE) You are right, that looks like a genuine bug. The last case of AIO_NOTCANCELLED should be ok, the caller should use normal completions to reap the remainders. I'll apply this. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe fio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
