weird error check for aio_cancel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



hi,

please look at the following patch.

YAMAMOTO Takashi

Signed-off-by: YAMAMOTO Takashi <yamamoto@xxxxxxxxxxxxx>

commit e7aa7a65700932fe68d96015c06e6e1b1ecea0da
Author: YAMAMOTO Takashi <yamamoto@xxxxxxxxxxxxx>
Date:   Fri Jun 11 12:32:42 2010 +0900

    fix a weird check of the return value of aio_cancel.
    
    i don't know what this 1 means in the first place but at least
    it isn't portable.  instead, check if the i/o has already
    completed. (AIO_ALLDONE)

diff --git a/engines/posixaio.c b/engines/posixaio.c
index 70282f2..7098d72 100644
--- a/engines/posixaio.c
+++ b/engines/posixaio.c
@@ -56,7 +56,7 @@ static int fio_posixaio_cancel(struct thread_data fio_unused *td,
 	struct fio_file *f = io_u->file;
 	int r = aio_cancel(f->fd, &io_u->aiocb);
 
-	if (r == 1 || r == AIO_CANCELED)
+	if (r == AIO_ALLDONE || r == AIO_CANCELED)
 		return 0;
 
 	return 1;
--
To unsubscribe from this list: send the line "unsubscribe fio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel]     [Linux SCSI]     [Linux IDE]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux