Re: Incorrect grub entry inserted by Preupgrade

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2010-05-27 at 17:37 +0300, Hassan Ibraheem wrote:
> Hi,
> I've just upgraded to Fedora 13 from 12 using preupgrade-cli, my /boot
> is too small unfortunately, so install.img wasn't downloaded.
> When I rebooted anaconda complained that it couldn't read the
> kickstart file, that's when I looked at the grub entry inserted by
> preupgrade:
> 
> 
> title Upgrade to Fedora 13 (Goddard)
> kernel /upgrade/vmlinuz preupgrade repo=hd::/var/cache/yum/preupgrade
> ks=hd:UUID=*-*-*-*-*:/upgrade/ks.cfgstage2=http://ftp.heanet.ie/pub/fedora/linux/releases/13/Fedora/i386/os/images/install.img
> initrd /upgrade/initrd.img
> 
> 
> for some reason, the space between "ks.cfg" and "stage2" was omitted.
> 
> 
> I've added the space manually, and successfully upgraded.
> 
> 
> Should I report that against preupgrade (or maybe grubby)? It looks
> like a minor issue, and I can't try to reproduce it now that I've
> already upgraded.

Please file against preupgrade.  This appears to only happen when using
preupgrade-cli with insufficient disk space in /boot.  I suspect the
following patch would fix the problem.

Thanks,
James

diff --git a/preupgrade-cli.py b/preupgrade-cli.py
index e9ca2a7..e4a0dab 100755
--- a/preupgrade-cli.py
+++ b/preupgrade-cli.py
@@ -232,7 +232,7 @@ class PreUpgradeCli(PreUpgrade, YumUtilBase):
             self.errorprint(message)
             # We fall back to getting stage2 from instrepo
             stage2url = os.path.join(self.instrepo.urls[0], self.mainimage)
-            extra_args += "stage2=" + stage2url
+            extra_args += " stage2=" + stage2url
 
 
         # Step 3: Find out what packages we need to download

Attachment: signature.asc
Description: This is a digitally signed message part

-- 
test mailing list
test@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe: 
https://admin.fedoraproject.org/mailman/listinfo/test

[Index of Archives]     [Fedora Desktop]     [Fedora SELinux]     [Photo Sharing]     [Yosemite Forum]     [KDE Users]

  Powered by Linux