On Thu, 2012-10-25 at 20:41 +0000, "Jóhann B. Guðmundsson" wrote: > On 10/25/2012 08:26 PM, Adam Williamson wrote: > > > On this topic...Ric Wheeler came up with some fairly good arguments in > > favour of keeping the LVM default and proposed it on the anaconda list > > this morning (actually I think the post may not have been approved yet, > > but it'll show up soon). Since we're post-freeze now I summarized the > > debate into a bug report and nominated it for NTH: > > > > https://bugzilla.redhat.com/show_bug.cgi?id=870207 > > > > I think it's still true to say that our *original* reasons for > > defaulting to LVM don't really hold any more, but Ric made some pretty > > decent *current* arguments for keeping that default until we switch to > > btrfs-by-default. > > First of all this has been known this whole time Ric is not bringing > anything new to the table and I nack to this proposal it's to dam late > in the release cycle to change this now and if we change this it means > we have to slip another week to properly test anaconda with lvm as > default against the alpha and beta criteria > > Can we please stop messing around with the installer! Like I said in the bug I also think it's pretty late to change this, but the change is in fact small and simple: the autopart code hasn't actually changed in newUI and has always had the ability to do both LVM and non-LVM layouts (in oldUI, remember, we gave you a checkbox to pick). All the patch does is change the default for the autopart algorithm, it's a two-liner: diff --git a/pyanaconda/ui/gui/spokes/storage.py b/pyanaconda/ui/gui/spokes/storage.py index 14ea404..6d7d9b6 100644 --- a/pyanaconda/ui/gui/spokes/storage.py +++ b/pyanaconda/ui/gui/spokes/storage.py @@ -337,8 +337,7 @@ class StorageSpoke(NormalSpoke, StorageChecker): self.data.autopart.encrypted = self.encrypted self.data.autopart.passphrase = self.passphrase - # no thanks, lvm - self.data.autopart.type = AUTOPART_TYPE_PLAIN + self.data.autopart.type = AUTOPART_TYPE_LVM self.clearPartType = CLEARPART_TYPE_NONE diff --git a/pyanaconda/ui/tui/spokes/storage.py b/pyanaconda/ui/tui/spokes/storage.py index c0a7cdd..b486657 100644 --- a/pyanaconda/ui/tui/spokes/storage.py +++ b/pyanaconda/ui/tui/spokes/storage.py @@ -229,8 +229,7 @@ class StorageSpoke(NormalTUISpoke): self.data.ignoredisk.onlyuse = self.selected_disks[:] self.data.clearpart.drives = self.selected_disks[:] - # no thanks, lvm - self.data.autopart.type = AUTOPART_TYPE_PLAIN + self.data.autopart.type = AUTOPART_TYPE_LVM if self.autopart: self.clearPartType = CLEARPART_TYPE_ALL and the code we're using is the same code we used and tested in all previous releases. So it's not actually a terribly scary change. On that basis I'm not horribly worried about doing it in practical terms, though I agree it would have been better to do it earlier. I'm about to post an updates.img to the bug you can use to test the change with TC6. I'm doing a first test of it right now and it seems to be working fine. -- Adam Williamson Fedora QA Community Monkey IRC: adamw | Twitter: AdamW_Fedora | identi.ca: adamwfedora http://www.happyassassin.net -- test mailing list test@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe: https://admin.fedoraproject.org/mailman/listinfo/test
