Hi, langpacks-<langcode> packages aren't necessarily installed for a primary locale. So I don't think such rich deps works as expected, particularly to figure out the regions for users. Plus, we have font packages installed by default to cover the majority of languages for convenience. So requiring font packages conditionally may not work too. BTW is there any reason that the package requires a non variable font package? If it works with the variable font, I think you can simply drop its dependency since we have google-noto-sans-cjk-vf-fonts installed by default as well as google-noto-sans-vf-fonts. Otherwise it may be better to fix it. On Wed, Aug 14, 2024 at 6:23 PM Miro Hrončok <mhroncok@xxxxxxxxxx> wrote: > > Hello, > > a package I co-mainatin bundles google-noto-sans-fonts and > google-noto-sans-cjk-fonts upstream. > > The fonts are removed from the package. We want to add a dependency on them, > like this: > > Requires: google-noto-sans-fonts > Requires: google-noto-sans-cjk-fonts > > However, it was pointed out in [1] that the cjk fonts are quire large and > probably no use for non-APAC users. (CJK is the shorthand collective name for > the Chinese, Japanese, and Korean writing systems.) > > We could do: > > Requires: google-noto-sans-fonts > Recommends: google-noto-sans-cjk-fonts > > But that still installs it to everybody by default. > > I was wondering if there is a rich dep magic I could use. > > E.g. > > Requires: google-noto-sans-fonts > Requires: (google-noto-sans-cjk-fonts if langpacks-fonts-...) > > However, there seem to be no general langpack for cjk. > > I could try to reverse engineering all the langpacks that need cjk fonts from, > the code [2], but perhaps there is a more general way? > > > I see that langpacks-fonts-ja/ko/zh_* Requires > google-noto-sans-mono-cjk-vf-fonts and google-noto-serif-cjk-vf-fonts. So I can do: > > Requires: (google-noto-sans-cjk-fonts if google-noto-serif-cjk-vf-fonts) > > But can I assume this will always be the case? > > [1] https://bugzilla.redhat.com/show_bug.cgi?id=2281392#c12 > [2] > https://github.com/prusa3d/PrusaSlicer/blob/version_2.8.0/src/slic3r/GUI/ImGuiWrapper.cpp#L220-L223 > -- > Miro Hrončok > -- > Phone: +420777974800 > Fedora Matrix: mhroncok > > -- > _______________________________________________ > packaging mailing list -- packaging@xxxxxxxxxxxxxxxxxxxxxxx > To unsubscribe send an email to packaging-leave@xxxxxxxxxxxxxxxxxxxxxxx > Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines > List Archives: https://lists.fedoraproject.org/archives/list/packaging@xxxxxxxxxxxxxxxxxxxxxxx > Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue -- Akira TAGOH -- _______________________________________________ packaging mailing list -- packaging@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to packaging-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/packaging@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
