Re: Mangling shebangs in text files: How to detect them, bug in the current implementation and possible solutions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 23. 09. 21 1:40, Josh Stone wrote:
On 9/22/21 4:21 AM, Miro Hrončok wrote:
Hello,

for many releases, Fedora has the brp-mangle-sehbangs BuildRoot Policy Script
that does the following:

   1) Gets all executable files in the buildroot
   2) Gets all "text" files from those
   3a) Mangles shebangs that are "wrong"
       (e.g. #!/usr/bin/env node -> #!/usr/bin/node)
   3b) Removes executable bits from "text" files without shebangs

While we're at it, can we teach the script to ignore Rust attributes?
They're written like #![attr...], and when that's on the first line some
editors try to be helpful and make the file executable. That's
considered an error with the current script since the "shebang" doesn't
start with '/', but it would be best IMO to have it remove the
executable bit.

I believe that currently the script would error:

ERROR: $f has shebang which doesn't start with '/' (#![attr...])

Have you ever seen that in a Fedora package?

--
Miro Hrončok
--
Phone: +420777974800
IRC: mhroncok
_______________________________________________
packaging mailing list -- packaging@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to packaging-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/packaging@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite Forum]     [KDE Users]

  Powered by Linux