On 8/27/2019 12:22 PM, Jason L Tibbitts III wrote:
> JC> while %set_build_flags is a bit more obscure.
>
> %set_build_flags is simply the intended way to accomplish what you're
> trying to accomplish. Adding a rather obscure creation of a fake
> configure script just so you can use another macro that you find less
> obscure doesn't feel like it's doing much in the way of reducing
> obscurity.
>
While I can understand that, I wasn't aware of that macro at all until
you brought it up... as were it seems several others.
Although I believe _configure overriding is simpler, I'd be fine with
either. I just think some sort of official advice for the situation is
warranted.
Also, FTR seems that in EL6 at least not only does %configure not
incorporate that, but %set_build_flags does something a bit different.
Not sure if that's a bug there:
-14: set_build_flags
CFLAGS="${CFLAGS:-%{build_cflags}}" ; export CFLAGS ;
CXXFLAGS="${CXXFLAGS:-%{build_cxxflags}}" ; export CXXFLAGS ;
FFLAGS="${FFLAGS:-%{build_fflags}}" ; export FFLAGS ;
FCFLAGS="${FCFLAGS:-%{build_fflags}}" ; export FCFLAGS ;
LDFLAGS="${LDFLAGS:-%{build_ldflags}}" ; export LDFLAGS
-14: configure
CFLAGS="${CFLAGS:-%optflags}" ; export CFLAGS ;
CXXFLAGS="${CXXFLAGS:-%optflags}" ; export CXXFLAGS ;
FFLAGS="${FFLAGS:-%optflags -I%_fmoddir}" ; export FFLAGS ;
%{_configure} --build=%{_build} --host=%{_host} \
(etc)
-jc
_______________________________________________
packaging mailing list -- packaging@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to packaging-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/packaging@xxxxxxxxxxxxxxxxxxxxxxx
