-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 05/31/2013 12:47 PM, Remi Collet wrote: > Le 31/05/2013 17:57, Jamie Nguyen a écrit : >> On 31/05/13 16:42, Antonio wrote: >>> I need a clarification about the Changelog section in a spec >>> file during a package review process. >>> >>> In particular, pursuant to >>> http://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs >>> guidelines: >>> >>>> Every time you make changes, that is, whenever you increment >>>> the >>> E-V-R >of a package, add a changelog entry. >>>> ... Changelog entries should provide a brief summary of the >>>> changes done to the package between releases, including >>>> noting updating to a new version, adding a patch, fixing >>>> other spec sections, note bugs fixed, and CVE's if any >>> >>> In https://bugzilla.redhat.com/show_bug.cgi?id=966201, David >>> says that Changelog changes' list is not necessary during >>> package review process because it is still a "initial package" >>> state. >>> >>> For all my packages and not only, every one always asks me to >>> update the Changelog, also for a minimal modification in a >>> package pre-review/review process. To be sure and to resolve >>> this issue with David, I need some clarification regard to how >>> to use properly the Changelog section since the first package >>> review submit. >> >> David is correct that updating the changelog is not a mandatory >> part of the review process, but at the same time it can be (and >> is often) very helpful. I've seen many reviewers request that the >> changelog is updated during the review process. For all of my >> review requests I increment the Release tag and add a changelog >> entry. It makes it then very easy to follow the evolution of the >> package. And for reviews that I perform myself, I always prefer >> packagers to increment Release and add a changelog entry. >> >> I'd say that if the reviewer assigns themselves to a review and >> requests nicely (as you have done) that the packager adds >> changelog entries for each change, then the packager should >> strive to do so, since making life easier for the reviewer can >> only be a good thing (especially since reviewing packages is >> often a thankless task). >> > > I agree. Updating changelog during review seems a very good > practice. > Yes, if nothing else it can help identify what has changed between iterations on the review (especially if a review is taken over by a new reviewer partway through). -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iEYEARECAAYFAlGo2ScACgkQeiVVYja6o6OSywCgmKYNFhhfR8vHqA0BMb2k7Wv8 XnIAn1v/fvmr+vJ6iHm7m5YrCEBh2d5l =NKPb -----END PGP SIGNATURE----- -- packaging mailing list packaging@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/packaging
