Orcan Ogetbil пишет:
I have 2 questions. The first one is brought to my attention by a
first time reviewer and he has got an interesting point.
The guidelines at
https://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags
say:
"Adding to and overriding or filtering parts of these flags is
permitted if there's a good reason to do so; the rationale for doing
so should be reviewed and documented in the specfile especially in the
override and filter cases."
As you probably know that some packages add their own compiler flags
on top of what we specified as %optflags. Until now, I did not do
anything about these flags unless they override our %optflags. Now,
having a second thought, I realized that the above statement can be
interpreted in two ways:
As I can understand primarily this required for the allowing Fedora set
of optimisation for current platform, for which package build. So, in
case when maintainer add flags which is important fo building,
performance, or changed as some workaround to bug - it is acceptable,
but need comment. Otherwise, we MUST rewrite developer flags to fedora
default %optflags.
Michael Schwendt point me in one of my own review request to this
guidelines: https://bugzilla.redhat.com/show_bug.cgi?id=454980#c37
--
Fedora-packaging mailing list
Fedora-packaging@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/fedora-packaging
