Re: Use of dos2unix in %prep

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Richard W.M. Jones wrote:
While a package was being reviewed, the reviewer picked up on a use of
the 'dos2unix --keepdate' command:

  https://bugzilla.redhat.com/show_bug.cgi?id=478640

The guidelines do indeed say not to use dos2unix, because quote "that
can cause build fail on FC3" (like I care).

  http://fedoraproject.org/wiki/Packaging/Guidelines#Rpmlint_Errors

But I've used dos2unix before,
I use /usr/bin/dos2unix to avoid build breakdowns should dos2unix be moved between packages.

 and it appears that using 'dos2unix
--keepdate' is a superior solution because it keeps the original
timestamp, and is generally simpler and more obvious to people reading
the specfile.
sigh, some people will never understand that keeping timestamps is painting bikesheds :(

So is this guideline for real?
I would label this a "historic wart" of FPG, the FPC should revisit.

Ralf

--
Fedora-packaging mailing list
Fedora-packaging@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/fedora-packaging

[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite Forum]     [KDE Users]

  Powered by Linux