<quote who="Michael Schwendt"> > On Tue, 12 Apr 2005 12:06:43 +0100 (BST), Gavin Henry wrote: > >> Dear all, >> >> Not sure if I should e-mail the Extras list or this, so here goes: > > Specific review requests should be posted to fedora-extras-list. > >> Anything stupid that I have missed? >> >> I have imported the srpm to Extras devel. > > CVS commits are posted to fedora-extras-commits list automatically: > http://www.redhat.com/mailman/listinfo/fedora-extras-commits > > I've posted a comment there (but included you in Cc in case you > didn't know about the list before). > > As I won't find time to take a deep look, another comment here. > The overly verbose > > %verify(user group mode md5 size mtime) > > in the %files section should be deleted alltogether unless you > have a good reason why to add them. > > >> %prep >> rm -rf %{buildroot} > > The rm -rf %buildroot is not needed here. > > > "install" with option "-p" would be nice, because it preserves timestamps > on installed files and enables users to see the age of static files > easily. Done. Can you point me to the wiki page that shows how to checkout your own module again, I've forgotten. -- Kind Regards, Gavin Henry. Managing Director. T +44 (0) 1224 279484 M +44 (0) 7930 323266 F +44 (0) 1224 742001 E ghenry@xxxxxxxxxxxxxxxxxx Open Source. Open Solutions(tm). http://www.suretecsystems.com/ -- Fedora-packaging mailing list Fedora-packaging@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-packaging
