Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476471 Fabian Affolter <fabian@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fabian@xxxxxxxxxxxxxxxxx --- Comment #1 from Fabian Affolter <fabian@xxxxxxxxxxxxxxxxx> 2008-12-17 04:12:12 EDT --- Can you please provide an URL to the spec file? It's much easier for possible reviewers to have a look at it. Some quick comments on your spec file: - The name of this package is a bit wired. Upper case, underscore, version, and language. According the other doc stuff (e.g. fedora-release-notes) 'fedora-security-guide' would be nice or 'linux-security-guide'. - 'Source0:' should point to the upstream source location, if possible. - About the .desktop file. The guidelines says that it should be include as 'SourceX:' https://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files See 'desktop-file-install usage' for details about the installation of this file. Get in touch with upstream and ask them to include the .desktop file. - There is no entry in your %changelog section https://fedoraproject.org/wiki/Packaging/Guidelines#Changelogs -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review