Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=475799 --- Comment #13 from Fabian Affolter <fabian@xxxxxxxxxxxxxxxxx> 2008-12-17 03:40:06 EDT --- Some comments on your spec file - License: GPLv2 What's is about the copyright in the NEWS file? - 'Source0: http://pidgin-musictracker.googlecode.com/files/pidgin-musictracker-0.4.4.tar.bz2' can be 'http://pidgin-musictracker.googlecode.com/files/musictracker-%{version}.tar.bz2' no worries about the version in the future to get the source - No 'BuildRequires' ? I think that this didn't work in mock. - This is a pidgin plugin but Pidgin is not a requirement? - 'make install DESTDIR=$RPM_BUILD_ROOT' better use 'make DESTDIR=%{buildroot} INSTALL="install -p" install' to preserves the files' timestamps. - '%doc AUTHORS ChangeLog COPYING NEWS README' The file THANKS is missing - For your file section, take a lot at https://fedoraproject.org/wiki/Packaging/Guidelines#Exclusion_of_Static_Libraries https://fedoraproject.org/wiki/Packaging/Guidelines#Relocatable_packages https://fedoraproject.org/wiki/PackageMaintainers/CreatingPackageHowTo#Macros - Your %changelog don't match the guidelines https://fedoraproject.org/wiki/Packaging/Guidelines#Changelogs -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review