Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=474908 --- Comment #1 from Orcan 'oget' Ogetbil <orcanbahri@xxxxxxxxx> 2008-12-06 15:42:28 EDT --- OK, I finished the review. There are a few minor issues (*) and I also have some questions (?): - rpmlint says xmms2-devel.x86_64: W: no-documentation xmms2-perl.x86_64: W: no-documentation xmms2-python.x86_64: W: no-documentation xmms2-ruby.x86_64: W: no-documentation but I couldn't find anything relevant in the available docs to put into these packages (except maybe the license files?), so these warnings can be ignored. ? I didn't find any occurrences of the clauses "GPL" or "Artistic" or "licensed under the same terms as perl itself." among the perl files. Is there a rule that any perl program has to be released under "GPL+ or Artistic"? I would also like to remind you that there is a .so file in the perl package that links against the libraries in the main package. - TODO file can be included in %doc ? Is the doxygen documentation useless? ? What package(s) own the %{perl_archlib}/Audio/ %{perl_archlib}/auto/Audio/ directories? Are they among the dependencies? ? Some files in the wafadmin directory have /usr/local/ /usr/lib/ directories hardcoded. Will these have any effect on the application? ? There are no .desktop files but why are there pixmaps? * The devel package has .pc files, hence we must require pkgconfig. * Please add the -v flag to the waf script so we can see what it is actually doing. When I did this, I found that the fedora specific compiler flag -O2 is being overwritten. This needs fixed. ? The following provides seemed weird to me: $ rpm -qp --provides xmms2-devel-0.5-1.fc10.x86_64.rpm (git DrLecter b63ec5a270cfde0ae3d59c9b89d860b8650e430f-dirty) commit: pkgconfig(xmms2-client) = 0.5 pkgconfig(xmms2-client-cpp) = 0.5 pkgconfig(xmms2-client-cpp-glib) = 0.5 pkgconfig(xmms2-client-ecore) = 0.5 pkgconfig(xmms2-client-glib) = 0.5 pkgconfig(xmms2-plugin) = 0.5 xmms2-devel = 0.5-1.fc10 xmms2-devel(x86-64) = 0.5-1.fc10 What is that git parenthesis about? Is that normal? * The devel package must require glib2-devel, qt-devel, boost-devel at the least (but I think this is all). * Double BR: libmodplug-devel * Unnecessary BRs: libcurl-devel (picked up by ecore-devel), glib2-devel (picked up by avahi-glib-devel, pulseaudio-libs-devel...), libogg-devel, libvorbis-devel (both picked up by libshout-devel), python-devel (picked up by Pyrex) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review