[Bug 459637] Review Request: svxlink - Repeater controller and EchoLink (simplex or repeater)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=459637


Jason Tibbitts <tibbs@xxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody@xxxxxxxxxxxxxxxxx    |tibbs@xxxxxxxxxxx
               Flag|                            |fedora-review?




--- Comment #7 from Jason Tibbitts <tibbs@xxxxxxxxxxx>  2008-12-06 15:41:07 EDT ---
Thanks for doing that.  It would be good to add a quick comment to the spec
near the License: tag indicating which parts are GPLv2 and which are GPLv2+ so
you don't have to look for the COPYRIGHT files.

I can't quite tell if the svxlink-server package needs a dependency on udev
(for /etc/udev/rules.d) or whether the dependency chain includes it.

I note that the .so files aren't executable.  I was under the impression that
they needed to be executable for things to work, and my systems don't seem to
have any non-executable so files in _libdir.

Any reason for not using the standard user management scriptlet?  As it is now,
your system fails badly if the svxlink user is defined somewhere other than
/etc/passwd (such as on my LDAP server).  Check
http://fedoraproject.org/wiki/Packaging/UsersAndGroups for more info; it's
basically just calling getent.  Also, you will need Requries(pre): shadow-utils
for that scriptlet.

* source files match upstream.  sha256sums:
  77d14a788ba1a9c5a2027f875790ec3eaeb5074ba48d0bb382c2b6992249a7d1  
   sounds-080730.tar.gz
  68039508fa77ac3daf648bc26b99029c867068a03b43aab6650101c2fc2ef107  
   svxlink-080730.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summaries are OK.
* descriptions are OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license texts included in package.
* latest version is being packaged.
* BuildRequires are proper.
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* debuginfo package looks complete.
* rpmlint has acceptable complaints.
* final provides and requires are sane:
  echolib-0.13.0-5.fc11.x86_64.rpm
   libecholib.so.0.13()(64bit)
   echolib = 0.13.0-5.fc11
   echolib(x86-64) = 0.13.0-5.fc11
  =
   /sbin/ldconfig
   libasyncaudio.so.0.16()(64bit)
   libasynccore.so.0.16()(64bit)
   libecholib.so.0.13()(64bit)
   libgcc_s.so.1()(64bit)
   libgcc_s.so.1(GCC_3.0)(64bit)
   libgsm.so.1()(64bit)

  echolib-devel-0.13.0-5.fc11.x86_64.rpm
   echolib-devel = 0.13.0-5.fc11
   echolib-devel(x86-64) = 0.13.0-5.fc11
  =
   echolib = 0.13.0
   libecholib.so.0.13()(64bit)

  libasync-0.16.1-5.fc11.x86_64.rpm
   libasyncaudio.so.0.16()(64bit)
   libasynccore.so.0.16()(64bit)
   libasynccpp.so.0.16()(64bit)
   libasyncqt.so.0.16()(64bit)
   libasync = 0.16.1-5.fc11
   libasync(x86-64) = 0.16.1-5.fc11
  =
   /sbin/ldconfig
   libICE.so.6()(64bit)
   libSM.so.6()(64bit)
   libX11.so.6()(64bit)
   libXcursor.so.1()(64bit)
   libXext.so.6()(64bit)
   libXft.so.2()(64bit)
   libXi.so.6()(64bit)
   libXinerama.so.1()(64bit)
   libXrandr.so.2()(64bit)
   libXrender.so.1()(64bit)
   libasyncaudio.so.0.16()(64bit)
   libasynccore.so.0.16()(64bit)
   libasynccpp.so.0.16()(64bit)
   libasyncqt.so.0.16()(64bit)
   libfontconfig.so.1()(64bit)
   libfreetype.so.6()(64bit)
   libgcc_s.so.1()(64bit)
   libgcc_s.so.1(GCC_3.0)(64bit)
   libjpeg.so.62()(64bit)
   libmng.so.1()(64bit)
   libpng12.so.0()(64bit)
   libqt-mt.so.3()(64bit)
   libsigc-1.2.so.5()(64bit)
   libz.so.1()(64bit)

  libasync-devel-0.16.1-5.fc11.x86_64.rpm
   libasync-devel = 0.16.1-5.fc11
   libasync-devel(x86-64) = 0.16.1-5.fc11
  =
   libasync = 0.16.1
   libasyncaudio.so.0.16()(64bit)
   libasynccore.so.0.16()(64bit)
   libasynccpp.so.0.16()(64bit)
   libasyncqt.so.0.16()(64bit)

  qtel-0.11.1-5.fc11.x86_64.rpm
   qtel = 0.11.1-5.fc11
   qtel(x86-64) = 0.11.1-5.fc11
  =
   libICE.so.6()(64bit)
   libSM.so.6()(64bit)
   libX11.so.6()(64bit)
   libXcursor.so.1()(64bit)
   libXext.so.6()(64bit)
   libXft.so.2()(64bit)
   libXi.so.6()(64bit)
   libXinerama.so.1()(64bit)
   libXrandr.so.2()(64bit)
   libXrender.so.1()(64bit)
   libasyncaudio.so.0.16()(64bit)
   libasynccore.so.0.16()(64bit)
   libasyncqt.so.0.16()(64bit)
   libecholib.so.0.13()(64bit)
   libfontconfig.so.1()(64bit)
   libfreetype.so.6()(64bit)
   libgcc_s.so.1()(64bit)
   libgcc_s.so.1(GCC_3.0)(64bit)
   libjpeg.so.62()(64bit)
   libmng.so.1()(64bit)
   libpng12.so.0()(64bit)
   libqt-mt.so.3()(64bit)
   libsigc-1.2.so.5()(64bit)
   libstdc++.so.6()(64bit)
   libstdc++.so.6(CXXABI_1.3)(64bit)
   libstdc++.so.6(GLIBCXX_3.4)(64bit)
   libstdc++.so.6(GLIBCXX_3.4.9)(64bit)
   libz.so.1()(64bit)

?  svxlink-server-0.10.1-5.fc11.x86_64.rpm
   ModuleDtmfRepeater.so()(64bit)
   ModuleEchoLink.so()(64bit)
   ModuleHelp.so()(64bit)
   ModuleParrot.so()(64bit)
   ModuleTcl.so()(64bit)
   config(svxlink-server) = 0.10.1-5.fc11
   svxlink-server = 0.10.1-5.fc11
   svxlink-server(x86-64) = 0.10.1-5.fc11
  =
   /bin/bash
   /bin/sh
   /usr/bin/tclsh
   config(svxlink-server) = 0.10.1-5.fc11
   libICE.so.6()(64bit)
   libSM.so.6()(64bit)
   libX11.so.6()(64bit)
   libXcursor.so.1()(64bit)
   libXext.so.6()(64bit)
   libXft.so.2()(64bit)
   libXi.so.6()(64bit)
   libXinerama.so.1()(64bit)
   libXrandr.so.2()(64bit)
   libXrender.so.1()(64bit)
   libasyncaudio.so.0.16()(64bit)
   libasynccore.so.0.16()(64bit)
   libasynccpp.so.0.16()(64bit)
   libasyncqt.so.0.16()(64bit)
   libecholib.so.0.13()(64bit)
   libfontconfig.so.1()(64bit)
   libfreetype.so.6()(64bit)
   libgcc_s.so.1()(64bit)
   libgcc_s.so.1(GCC_3.0)(64bit)
   libgsm.so.1()(64bit)
   libjpeg.so.62()(64bit)
   libmng.so.1()(64bit)
   libpng12.so.0()(64bit)
   libpopt.so.0()(64bit)
   libpopt.so.0(LIBPOPT_0)(64bit)
   libqt-mt.so.3()(64bit)
   libsigc-1.2.so.5()(64bit)
   libspandsp.so.1()(64bit)
   libstdc++.so.6()(64bit)
   libstdc++.so.6(CXXABI_1.3)(64bit)
   libstdc++.so.6(GLIBCXX_3.4)(64bit)
   libstdc++.so.6(GLIBCXX_3.4.9)(64bit)
   libtcl8.5.so()(64bit)
   libz.so.1()(64bit)
?   Needs udev?

  svxlink-server-devel-0.10.1-5.fc11.x86_64.rpm
   svxlink-server-devel = 0.10.1-5.fc11
   svxlink-server-devel(x86-64) = 0.10.1-5.fc11
  =

* shared libraries installed; ldconfig called properly.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
? file permissions are appropriate.
* no generically named files
X issues with scriptlets 
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* headers are in the -devel subpackages.
* no pkgconfig files.
* no static libraries.
* no libtool .la files.
* desktop files valid and installed properly.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]