Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226659 Orcan 'oget' Ogetbil <orcanbahri@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |orcanbahri@xxxxxxxxx, | |tibbs@xxxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |orcanbahri@xxxxxxxxx Flag| |fedora-review? --- Comment #1 from Orcan 'oget' Ogetbil <orcanbahri@xxxxxxxxx> 2008-12-02 22:47:39 EDT --- Here is the long awaited review for this package: * Description: The description is insufficient. The term "root window" does not mean much to most people. What does "displays images on the root window" mean? I think it should be replaced by modern day terms such as "sets the wallpaper". * rpmlint says: xsri.spec:20: W: setup-not-quiet Use a -q flag on %setup macro xsri.spec: E: no-cleaning-of-buildroot %install buildroot must be cleaned at the beginning of %install xsri.src: W: no-url-tag I guess this package does not have an URL at all, so this is fine. xsri.x86_64: E: zero-length /usr/share/doc/xsri-2.1.0/NEWS The file NEWS is empty, doesn't need to be packaged. xsri.x86_64: W: incoherent-version-in-changelog 2.1.0-15 ['1:2.1.0-15.fc10', '1:2.1.0-15'] Typo? Can be fixed easily. * Group: System Environment/Base Is this the best one to pick? * We prefer %defattr(-,root,root,-) * BuildRequires: gtk2-devel >= 1.3.13 From the guidelines: "if the lowest possible requirement is so old that nobody has a version older than that installed on any target distribution release, there's no need to include the version in the dependency at all." gtk2-1.3 is ancient, so no need to use the specific version here. * Parallel make must be supported whenever possible. If it is not supported, this should be noted in the SPEC file as a comment. I added Jason Tibbitts to the CC since he's the last known maintainer. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review