[Bug 461899] Review Request: thebridge - ILink/EchoLink compatible conference bridge

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=461899


Jason Tibbitts <tibbs@xxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody@xxxxxxxxxxxxxxxxx    |tibbs@xxxxxxxxxxx
               Flag|                            |fedora-review?




--- Comment #4 from Jason Tibbitts <tibbs@xxxxxxxxxxx>  2008-12-02 21:19:16 EDT ---
I cannot seem to fetch Source0; I think you need
http://downloads.sourceforge.net/cqinet/%{name}-%{version}.tgz. 

You are missing the dependencies for the calls you make in the scriptlets:

Requires(post): chkconfig
Requires(preun): chkconfig
Requires(preun): initscripts
Requires(postun): initscripts

* source files match upstream.  sha256sum:
   401646f336b052555abc776e40e94b3990b7c198f2a9ec65bf45ee45acbab6a2  
   thebridge-1.06.tgz
  (after fixing Source0: URL so that it downloads)
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* debuginfo package looks complete.
* rpmlint is silent.
X final provides and requires:
   config(thebridge) = 1.06-2.fc11
   thebridge = 1.06-2.fc11
   thebridge(x86-64) = 1.06-2.fc11
  =
   /bin/bash
   /bin/sh
   config(thebridge) = 1.06-2.fc11
   libz.so.1()(64bit)
  Missing scriptlet dependencies.

* no shared libraries are added to the regular linker search paths.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no generically named files
* scriptlets OK (service management).
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no static libraries.
* no libtool .la files.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]