Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=470792 --- Comment #4 from Alexander Kurtakov <akurtako@xxxxxxxxxx> 2008-11-26 04:36:34 EDT --- Updated : Spec URL: http://akurtakov.fedorapeople.org/eclipse-shelled.spec SRPM URL: http://akurtakov.fedorapeople.org/eclipse-shelled-1.0.3-2.fc9.src.rpm (In reply to comment #3) > * Whenever you are uploading a new release, don't forget the bump the release > number. This applies even during the review process. > > * rpmlint says > eclipse-shelled.noarch: W: no-documentation > eclipse-shelled.src: W: strange-permission fetch-shelled.sh 0764 > > ** At least these files need to go to %doc. > ./com.something.eclipse.shelled-feature/license.html > ./com.something.eclipse.shelled-feature/cpl-v10.html > ./com.something.eclipse.shelled.resources/about.html > (Check the sample spec file at the eclipse guidelines) > The other about.html files have the same content. > Other than this, what are all those manpages for? > > ** Afaik, we use 644 for source files. Fixed. > > * You do not need > BuildRequires: zip > BuildRequires: lzma Fixed. > > * We prefer %defattr(-,root,root,-) Fixed. > > * Use the %{version} macro whenever applicable (e.g. source0). Fixed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review