Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=458866 --- Comment #3 from Pavel Alexeev <pahan@xxxxxxxxxxxxxxx> 2008-11-22 11:25:53 EDT --- (In reply to comment #2) > A couple of comments: > > If you're going to, for whatever reason, use macros like %__make and %{__mv}, > you need to be consistent: either use the brackets or don't, and then you need > to use %{__rm} instead of just "rm". Or just drop the macros entirely and save > the typing. I do not see this so much sense to pay attention. But ok, I fix it. > rpmlint complains about the .packlist file. Honestly I'm not sure why you > would even need to package it, and if you check the perl package template > you'll see that it deletes .packlist files and then goes through and deletes > empty directory trees. In fact, perhaps you might want to take a look at the > template; it might give you some hints for better ways to do some things. > Install the rpmdevtools package and look at > /etc/rpmdevtools/spectemplate-perl.spec. I have long thought about it file... Very thanks for this hints. I get few lines fronm this spec template (see spec changelog for more details). > In any case, it's always useful to run rpmlint on your packages (both the > source RPM and the final built packages). Off course! Now it is produce only 1 warning, but it is too erroneously: $ rpmlint -i xls2csv-1.06-1.fc9.src.rpm xls2csv.src:32: W: rpm-buildroot-usage %build %{__perl} Makefile.PL INSTALLDIRS="vendor" PREFIX="%{buildroot}%{_prefix}" $RPM_BUILD_ROOT should not be touched during %build or %prep stage, as it will break short circuiting. so, it is wrong, because usage of %{buildroot} there is not touch this dir!!! This is needed only for configuration build. http://hubbitus.net.ru/rpm/Fedora9/xls2csv/xls2csv-1.06-1.fc9.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review