Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=458866 --- Comment #2 from Jason Tibbitts <tibbs@xxxxxxxxxxx> 2008-11-20 22:54:25 EDT --- A couple of comments: If you're going to, for whatever reason, use macros like %__make and %{__mv}, you need to be consistent: either use the brackets or don't, and then you need to use %{__rm} instead of just "rm". Or just drop the macros entirely and save the typing. rpmlint complains about the .packlist file. Honestly I'm not sure why you would even need to package it, and if you check the perl package template you'll see that it deletes .packlist files and then goes through and deletes empty directory trees. In fact, perhaps you might want to take a look at the template; it might give you some hints for better ways to do some things. Install the rpmdevtools package and look at /etc/rpmdevtools/spectemplate-perl.spec. In any case, it's always useful to run rpmlint on your packages (both the source RPM and the final built packages). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review