Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=472274 Miroslav Lichvar <mlichvar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |mlichvar@xxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |mlichvar@xxxxxxxxxx Flag| |fedora-review+ --- Comment #1 from Miroslav Lichvar <mlichvar@xxxxxxxxxx> 2008-11-20 12:12:58 EDT --- - rpmlint output: atari++.x86_64: W: file-not-utf8 /usr/share/doc/atari++-1.55/CREDITS atari++.x86_64: W: invalid-license TPL Not a blocker, but please convert also CREDITS in the spec. TPL is a valid license. - the package is named according to the Package Naming Guidelines - the spec file name matches the base package %{name} - the package meets the Packaging Guidelines - the package is licensed with a Fedora approved license (TPL) - the License field in the package spec file matches the actual license - the file containing the text of the license(s) for the package is included in %doc - the spec file is written in American English - the spec file for the package is legible - the source matches the upstream source - all build dependencies are listed in BuildRequires - the package does not contain any duplicate files in the %files listing - permissions on files are set properly - the package has a %clean section, which contains rm -rf $RPM_BUILD_ROOT - the package consistently uses macros - the package contains code, or permissible content - files included as %doc don't affect the runtime of the application - the package does not own files or directories already owned by other packages - at the beginning of %install, the package runs rm -rf $RPM_BUILD_ROOT - all filenames in rpm packages are valid UTF-8 - the package builds in mock (at least on x86_64) - the package functions as described Approved. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review