[Bug 472149] Review Request: refmac-dictionary - chemical ligand dictionaries

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=472149





--- Comment #2 from Tim Fenn <fenn@xxxxxxxxxxxx>  2008-11-19 14:12:44 EDT ---
(In reply to comment #1)
> suggestions
> 1) rpmlint is NOT silent for SRPM and for RPM.
> refmac-dictionary.noarch: W: no-version-in-last-changelog
> refmac-dictionary.src: W: no-version-in-last-changelog
> ==> missing version from changelog. Follow guidelines 
> http://fedoraproject.org/wiki/PackagingGuidelines#Changelogs
> 

Oops, fixed.

> 2) Don't mix macros follow
> http://fedoraproject.org/wiki/PackagingGuidelines#Macros
> either use %{buildroot}  OR $RPM_BUILD_ROOT

Fixed.

Spec URL: http://www.stanford.edu/~fenn/packs/refmac-dictionary.spec
SRPM URL:
http://www.stanford.edu/~fenn/packs/refmac-dictionary-5.02-2.f8.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]