Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467791 Lucian Langa <cooly@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #5 from Lucian Langa <cooly@xxxxxxxxxxxx> 2008-11-17 14:48:03 EDT --- Review: OK source files match upstream (using corrected URL): c342ffe77055d4248a38f0b380f28c1b vtun-3.0.1.tar.gz OK package meets naming and versioning guidelines. OK specfile is properly named, is cleanly written and uses macros consistently. OK summary is OK. OK description is OK. OK dist tag is present. OK build root is OK. OK license field matches the actual license. OK license is open source-compatible. OK license text included in package. OK BuildRequires are proper. N/A compiler flags are appropriate. OK %clean is present. OK package builds in mock (rawhide, x86_64). OK package installs properly. OK debuginfo package looks complete. OK rpmlint is silent. vtun.x86_64: E: non-readable /etc/vtund.conf 0600 vtun.x86_64: W: log-files-without-logrotate /var/log/vtund vtun.x86_64: W: incoherent-subsys /etc/rc.d/init.d/vtund $prog First error and last warning can be ignored. While the second warning about logfile wont't work for this package. OK final provides and requires are sane: vtun = 3.0.1-2.fc10 vtun(x86-64) = 3.0.1-2.fc10 = /bin/sh /sbin/chkconfig /sbin/service config(vtun) = 3.0.1-2.fc10 libcrypto.so.7()(64bit) liblzo2.so.2()(64bit) libz.so.1()(64bit) xinetd N/A no shared libraries are added to the regular linker search paths. OK owns the directories it creates. OK doesn't own any directories it shouldn't. OK no duplicates in %files. OK file permissions are appropriate. OK scriptlets present look OK OK initscript looks OK. OK code, not content. OK documentation is small, so no -doc subpackage is necessary. OK %docs are not necessary for the proper functioning of the package. OK no headers. OK no pkgconfig files. OK no static libraries. OK no libtool .la files. N/A not a gui app, no desktop file Suggestions: - Use "|| :" at the end of commands in scriptlets because RPM will abort scripts in the event of errors. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review