Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468823 Nicolas Mailhot <nicolas.mailhot@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |needinfo?(tagoh@xxxxxxxxxx) --- Comment #6 from Nicolas Mailhot <nicolas.mailhot@xxxxxxxxxxx> 2008-11-10 03:20:43 EDT --- (In reply to comment #5) > (In reply to comment #3) > I've already asked on fedora-legal-list, and just followed him to describe > License tag - > https://www.redhat.com/archives/fedora-legal-list/2008-October/msg00022.html If you could convince spot to publish this on his "licenses approved for fonts use" wiki page, that would make it easier for the next reviewers. Anyway > > 2. please follow the font packaging process outlined on > > http://fedoraproject.org/wiki/Font_package_lifecycle > > and in particular create a wiki page that describes your font and can be > > referenced in release notes > > Just created: https://fedoraproject.org/wiki/Hanazono_font Nice. You just need to remove the : before Category to activate them (fixed, I must rework the template help, everyone makes the same mistake) > > 3. your fontconfig priority (59) is a little low, our guidelines states CJK > > fonts should be in the 65-69 range > > http://fedoraproject.org/wiki/Fontconfig_packaging_tips#Simple_priority_lists > > > > 4. your fontconfig rule is a bit more convoluted than what we usually do. It > > probably works but please get Behdad to review it (and ok it there). > > I'd like to push this font prior to sazanami-mincho.ttf which we defaults for > Serif for Japanese, because the quality is better than it. I'm not sure what's > the right thing to do that for fontconfig config. that would be appreciated if > someone could helps me. Ultimately, Behdad is the best judge of us all on fontconfig stuff. > > 5. please also alias the font the other way, so fontconfig knows it should use > > serif fonts to complete HanaMin > > http://fedoraproject.org/wiki/Fontconfig_packaging_tips#Generic_names > > Fixed in the updated package. Nope, the rule I referenced would have been <alias> <family>HanaMin</family> <default> <family>serif</family> </default> </alias> The rule you added is equivalent to the one you already had, without the ja test. The fun thing is that your original rule needs to be placed after conf.d/65-nonlatin.conf to work, and your second rule needs to be placed before, so you can't use both in the same file :p Thus I'd advise to 1. keep your original rule 2. add the one I just wrote 3. use 66 as fontconfig prio 4. test test test > > 7. you can drop the -f argument to fc-cache for releases ≥ Fedora 9 > > Can you update the template page as well to see what's the expected thing > hereafter? It's documented in the comments nobody seems to read :) I'll drop it as soon as Fedora 8 in un-supported. > Spec URL: http://tagoh.fedorapeople.org/hanazono-fonts/hanazono-fonts.spec > SRPM URL: > http://tagoh.fedorapeople.org/hanazono-fonts/hanazono-fonts-20081012-2.fc9.src.rpm Appart from the fontconfig bit, you're almost there -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review