Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469317 Lucian Langa <cooly@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #6 from Lucian Langa <cooly@xxxxxxxxxxxx> 2008-11-07 05:11:12 EDT --- Thank you. Review: OK source files match upstream : 4f8db3c524c1014db5842ca2dbd575aa lynis-1.2.1.tar.gz OK package meets naming and versioning guidelines. OK specfile is properly named, is cleanly written and uses macros consistently. OK summary is OK. OK description is OK. OK dist tag is present. OK build root OK license field matches the actual license. OK license is open source-compatible. OK license text included in package. N/A BuildRequires are proper. N/A compiler flags are appropriate. OK %clean is present. OK package builds in mock (rawhide, x86_64). OK package installs properly. N/A debuginfo package looks complete. OK rpmlint is silent. OK final provides and requires are sane: config(lynis) = 1.2.1-2.fc10 lynis = 1.2.1-2.fc10 = /bin/sh config(lynis) = 1.2.1-2.fc10 rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 N/A no shared libraries are added to the regular linker search paths. OK owns the directories it creates. OK doesn't own any directories it shouldn't. OK no duplicates in %files. OK file permissions are appropriate. OK no scriptlets present. OK code, not content. OK documentation is small, so no -doc subpackage is necessary. OK no headers. OK no pkgconfig files. OK no static libraries. OK no libtool .la files. N/A not GUI application. Suggestion: Please consider doing something about header of /etc/lynis/default.prf as it might seem confusing # # Do NOT change this file, as it will be overwritten while upgrading. Instead # make a copy of this file and adjust it. # I think is should be changed upstream. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review