Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=246525 --- Comment #24 from Nicolas Chauvet (kwizart) <kwizart@xxxxxxxxx> 2008-10-28 05:34:45 EDT --- 1* Fix License to LGPLv2+ I don't think there is a LGPLv2 short name as every files under 2.1 should be redistributable under 3 with the LGPL case (in the contrary of the GPL). 2* -devel requires too much: from what is exposed to the API (grep include /usr/include/mini/* -R ) Only Requires: libGL-devel libGLU-devel curl-devel should be needed (along with pkgconfig). So I wonder if -lglut and requires x11 xmu from Mini.pc shoudn't be moved to Libs.private instead. 3* - the package install headers in the default include directory: (includedir=/usr/include from Mini.pc) This is perfectly possible , but IMO produce common error since pkg-config CFLAGS detection can be avoided by the dependant package. If used accurately pkg-config provides a level of abstraction to provides for the headers in case of dual API (LibMini-1.0.pc can be used to access headers in /usr/include/libMini-1.0/mini/mini.h along with the previous API) This is just a warning 4* There is a problem at link time indeed. (where sed -i -e 's! -shared ! -Wl,--as-needed\0!g' libtool seems a correct workaround for now). 2* will need to be investigated with a dependent package and 1* could be fixed then. 3* 4* are optionals and can be fixed later. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review