[Bug 466737] Review Request: matio - Library for reading/writing Matlab MAT files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=466737


Jussi Lehtola <jussi.lehtola@xxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEW
                 CC|                            |jussi.lehtola@xxxxxx




--- Comment #5 from Jussi Lehtola <jussi.lehtola@xxxxxx>  2008-10-26 09:37:09 EDT ---
1. Why don't you have just one patch for the fortran-related stuff? Remove
commented sed line.

2. To my understanding you don't need the zlib patch, since you require zlib >=
1.2.3 (the bug is only present in zlib 1.2.2). Remove patch0.

3. Remove all rpath related stuff, matio builds fine without them.

4. Please don't delete man files - rename them all to begin with, say matio-.

5. Add requires:
%if 0%{?fedora} > 8
BuildRequires:  texlive-latex
%else
BuildRequires:  tetex-latex
%endif

and get rid of the doxygen stuff in the spec file.

6. Move PDF to builddir and add it in %doc.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]