Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459989 --- Comment #8 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2008-10-25 10:03:32 EDT --- For CFLAGS issue (In reply to comment #7) > I think that the makefile don't respects the CFLAGS then because your spec is > not compiling with the flags, Well, actually %configure sets CFLAGS as environment (see what %configure does by $ rpm --eval %configure). However for this package configure{,ac} resets CFLAGS environment configure.ac says: ------------------------------------------------------------ 92 AC_C_CONST 93 94 CFLAGS="-pedantic-errors -Werror -Wall -g" 95 96 dnl Done. ------------------------------------------------------------ The line 94 resets CFLAGS, which is why Fedora specific compilation flags are ignored. For this package ------------------------------------------------------------ %prep %setup -q sed -i.optflags -e '/^CFLAGS=/d' configure %build ...... ------------------------------------------------------------- will pass Fedora cflags (note: with Fedora cflags this package won't build with -Werror). By the way * "BuildRequires: guile >= 1.8 vte" are redundant because there are already "BuildRequires: guile-devel >= 1.8 vte-devel" * Please make it sure that all directories which are created when installing this package are correctly owned by this package. Currently the directory %_datadir/%name and some directories under this directory are not owned by any packages. https://fedoraproject.org/wiki/Packaging/UnownedDirectories -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review