[Bug 459924] Review Request: Homestead - 3D real-time network visualiser

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=459924





--- Comment #17 from R P Herrold <herrold@xxxxxxxxxxxx>  2008-10-24 12:36:21 EDT ---
An Implementation of comment 15 
   https://bugzilla.redhat.com/show_bug.cgi?id=459924#c15
showing a vendor and dist tag neutral packaging approach, and a 'worked case'
diff are as follows:

[herrold@centos-5 homestead]$ ls
homestead-0.86-1.fc10.src.rpm  homestead.desktop-RPH~  homestead.spec-RPH
homestead.desktop              homestead.spec          homestead.spec-RPH~
homestead.desktop-ORIG         homestead.spec~
homestead.desktop-RPH          homestead.spec-ORIG
[herrold@centos-5 homestead]$ rpm -qlp
/home/herrold/rpmbuild/SRPMS/homestead-0.86-1orc.src.rpm
homestead.desktop
homestead.png
homestead.spec
homestead086.tar.gz
[herrold@centos-5 homestead]$ rpm -qlp
/home/herrold/rpmbuild/RPMS/x86_64/homestead-0.86-1orc.x86_64.rpm
/usr/bin/homestead
/usr/sbin/hsen
/usr/share/applications/orc-homestead.desktop
/usr/share/doc/homestead-0.86
/usr/share/doc/homestead-0.86/COPYING
/usr/share/doc/homestead-0.86/ChangeLog
/usr/share/doc/homestead-0.86/README
/usr/share/man/man1/homestead.1.gz
/usr/share/man/man8/hsen.8.gz
/usr/share/pixmaps/homestead.png
[herrold@centos-5 homestead]$ diff -u homestead.spec-ORIG homestead.spec
--- homestead.spec-ORIG 2008-10-24 11:49:24.000000000 -0400
+++ homestead.spec      2008-10-24 12:32:47.000000000 -0400
@@ -1,5 +1,5 @@
 %define srcversion 086
-%define        vendor  '%vendor%nil'
+%define        localvendor     %vendor%nil

 Name:           homestead
 Version:        0.86
@@ -49,7 +49,10 @@
 rm -rf %{buildroot}
 make install DESTDIR=%{buildroot}

-desktop-file-install --dir=%{buildroot}%{_datadir}/applications \
+#      seemingly 'desktop-file-install' is needed as its requirements
+#      could somehow not be handled by 'install' at freedesktop.org for
+#      managing .desktop files, whereas 'install' seems fine for pixmaps
+desktop-file-install --vendor=%localvendor
--dir=%{buildroot}%{_datadir}/applications \
 %{SOURCE1}

 install -p -D -m 0644 %{SOURCE2} %{buildroot}%{_datadir}/pixmaps/%{name}.png
@@ -66,7 +69,10 @@
 %{_mandir}/man1/%{name}.*
 %{_mandir}/man8/hsen.*
 %{_datadir}/pixmaps/%{name}.png
-%{_datadir}/applications/%{name}.desktop
+#
+#      two possible approaches here --specific or wildcarded
+%{_datadir}/applications/%{localvendor}-%{name}.desktop
+%{_datadir}/applications/*%{name}.desktop


 %changelog
[herrold@centos-5 homestead]$

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]