Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468287 Christopher D. Stover <quantumburnz@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hdegoede@xxxxxxxxxx, | |quantumburnz@xxxxxxxxxxx --- Comment #2 from Christopher D. Stover <quantumburnz@xxxxxxxxxxx> 2008-10-24 12:20:08 EDT --- ***Unofficial Review*** This is a pretty easy review considering "- now meets Fedora packaging guidelines too" is a change in 2.19.1-1. :D However, here are my comments. * Output from rpmlint: cim-schema.src: W: invalid-license Any permissive 1 packages and 0 specfiles checked; 0 errors, 1 warnings. Hopefully Spot can provide some insight into that for you. * In your %install macro, you have MOFDIR=/usr/share/mof. I don't think it's required but you can substitute %{_datadir} for /usr/share. The list of these macros is here: https://fedoraproject.org/wiki/Packaging/RPMMacros. * Builds without any problems on i386 32-bit. Looks pretty good to me. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review