Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=462251 --- Comment #31 from Tim Fenn <fenn@xxxxxxxxxxxx> 2008-10-17 15:13:12 EDT --- (In reply to comment #30) > For -6: > > * Python module dependency > - Would you check python module dependency again? > > For example pmg_tk/startup/apbs_tools.py says > ----------------------------------------------------- > 46 > 47 import os,math > 48 import Tkinter > 49 from Tkinter import * > 50 import Pmw > ----------------------------------------------------- > so this script requires tkinter (note: tkinter > requires tk and tcl) > Right, but python-pmw pulls tkinter in already. > And another example is that pmg_wx/__init__.py, > which contains: > ----------------------------------------------------- > 22 import threading > 23 import sys > 24 from wxPython.wx import * > 25 > ----------------------------------------------------- > This scripts requires wxPython. > However these dependencies may be optional and > I am not sure what python modules pymol requires > _at least_. > wxPython can be used as an alternative to tcl/tk, but is optional. I guess in which case the pmg_wx module should be removed? > * optflags > - build.log still says that compiler options "-ffast-math -funroll-loops -O3" > are used: > http://koji.fedoraproject.org/koji/taskinfo?taskID=886320 > Please patch these options out (I guess that changing ext_comp_args > in setup.py will do this). > ! Note that Fedora specific compilation flags should not be > removed. doh! Fixed. spec url: http://www.stanford.edu/~fenn/packs/pymol.spec srpm url: http://www.stanford.edu/~fenn/packs/pymol-1.1-7.20081015svn3468.f8.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review