Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=461131 --- Comment #45 from Pavel Alexeev <pahan@xxxxxxxxxxxxxxx> 2008-10-06 18:49:15 EDT --- (In reply to comment #44) > Shouldn't kde supportr be build in the default case? > That would mean using > > %bcond_with kde Yes, off course. Why we may want disable kde support by default? > Now the %post -p isn't used anymore By link what you provided befor it is mentioned as alternative. > you have to add explicitely: > > Requires(postun): /sbin/ldconfig > Requires(post): /sbin/ldconfig Hm... Sure? Din not /sbin/ldconfig generic?? > A suggestion: in the spec file, lines are not cut at 80 columns, though it is > quite convenient when editing in a console since this is the default width, and > also it is in general more readable, longer lines are, in my opinion, less > easy to read. Of course this doesn't apply to long lines that are long because > of an usrl or a string that shouldn't be cut. The suggestion would be to cut at > 80 columns more systematically. This is only a suggestion. In most cases, in package descriptions and other I'm wrap text in width of 80 characters... I will try to be careful in the future. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review