Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=461131 --- Comment #44 from Patrice Dumas <pertusus@xxxxxxx> 2008-10-06 17:28:09 EDT --- Shouldn't kde supportr be build in the default case? That would mean using %bcond_with kde Now the %post -p isn't used anymore, you have to add explicitely: Requires(postun): /sbin/ldconfig Requires(post): /sbin/ldconfig A suggestion: in the spec file, lines are not cut at 80 columns, though it is quite convenient when editing in a console since this is the default width, and also it is in general more readable, longer lines are, in my opinion, less easy to read. Of course this doesn't apply to long lines that are long because of an usrl or a string that shouldn't be cut. The suggestion would be to cut at 80 columns more systematically. This is only a suggestion. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review