Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=464424 --- Comment #17 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2008-10-02 05:08:51 EDT --- Some notes: * EVR - At least EVR (Epoch-Version-Release) needs fixing: https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Pre-Release_packages * configure - Doesn't the following work? ----------------------------------------------------------- # Single precision mkdir single cd single ln -sf ../configure %configure \ --disable-rpath --enable-shared \ --disable-static --enable-float \ ....... ----------------------------------------------------------- * Namespace in %_bindir, generic names - Your srpm installs many exectables under %_bindir, which is not desired. Also some files has too generic names (like luck, wheel, highway, and so on), which is rather a blocker. Please move (almost all) executables under %_bindir to %_libexecdir/%name, for example and add executables under %_bindir which are _really_ needed. * Duplicate files ----------------------------------------------------------- $ rpm -qlp *rpm | sort | uniq -d /usr/bin/GMXRC /usr/bin/GMXRC.bash /usr/bin/GMXRC.csh /usr/bin/GMXRC.zsh /usr/bin/demux.pl ------------------------------------------------------------ - Fix these. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review