Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=464432 Dominik 'Rathann' Mierzejewski <rpm@xxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review? --- Comment #7 from Dominik 'Rathann' Mierzejewski <rpm@xxxxxxxxxxxxxx> 2008-10-01 20:18:45 EDT --- OK'd items omitted. - MUST: rpmlint must be run on every package. The output should be posted in the review. $ rpmlint /var/lib/mock//fedora-rawhide-i386/result octopus.i386: W: dangling-relative-symlink /usr/lib/debug/.build-id/f8/9fbfbbed296d4a83448b1549262a7c9a7ae490 ../../../../bin/oct-test_mpi octopus.i386: W: hidden-file-or-dir /usr/lib/debug/.build-id octopus.i386: W: hidden-file-or-dir /usr/lib/debug/.build-id octopus.i386: W: dangling-relative-symlink /usr/lib/debug/.build-id/32/6af5072f170e31d82e0f48aab7f5686283d55c ../../../../bin/octopus_mpi octopus.i386: W: unstripped-binary-or-object /usr/lib/debug/usr/bin/oct-cross-section.debug octopus.i386: E: statically-linked-binary /usr/lib/debug/usr/bin/oct-cross-section.debug octopus.i386: W: unstripped-binary-or-object /usr/lib/debug/usr/bin/oct-rsf.debug octopus.i386: E: statically-linked-binary /usr/lib/debug/usr/bin/oct-rsf.debug octopus.i386: W: unstripped-binary-or-object /usr/lib/debug/usr/bin/octopus_mpi.debug octopus.i386: E: statically-linked-binary /usr/lib/debug/usr/bin/octopus_mpi.debug octopus.i386: W: unstripped-binary-or-object /usr/lib/debug/usr/bin/oct-test_mpi.debug octopus.i386: E: statically-linked-binary /usr/lib/debug/usr/bin/oct-test_mpi.debug octopus.i386: W: unstripped-binary-or-object /usr/lib/debug/usr/bin/oct-help.debug octopus.i386: E: statically-linked-binary /usr/lib/debug/usr/bin/oct-help.debug octopus.i386: W: unstripped-binary-or-object /usr/lib/debug/usr/bin/octopus.debug octopus.i386: E: statically-linked-binary /usr/lib/debug/usr/bin/octopus.debug octopus.i386: W: unstripped-binary-or-object /usr/lib/debug/usr/bin/oct-test.debug octopus.i386: E: statically-linked-binary /usr/lib/debug/usr/bin/oct-test.debug octopus.i386: W: unstripped-binary-or-object /usr/lib/debug/usr/bin/oct-center-geom.debug octopus.i386: E: statically-linked-binary /usr/lib/debug/usr/bin/oct-center-geom.debug octopus.i386: W: unstripped-binary-or-object /usr/lib/debug/usr/bin/oct-xyz-anim.debug octopus.i386: E: statically-linked-binary /usr/lib/debug/usr/bin/oct-xyz-anim.debug octopus.i386: W: unstripped-binary-or-object /usr/lib/debug/usr/bin/oct-vibrational.debug octopus.i386: E: statically-linked-binary /usr/lib/debug/usr/bin/oct-vibrational.debug octopus.i386: W: unstripped-binary-or-object /usr/lib/debug/usr/bin/oct-harmonic-spectrum.debug octopus.i386: E: statically-linked-binary /usr/lib/debug/usr/bin/oct-harmonic-spectrum.debug octopus.i386: W: unstripped-binary-or-object /usr/lib/debug/usr/bin/oct-broad.debug octopus.i386: E: statically-linked-binary /usr/lib/debug/usr/bin/oct-broad.debug octopus.i386: W: unstripped-binary-or-object /usr/lib/debug/usr/bin/oct-oscillator-strength.debug octopus.i386: E: statically-linked-binary /usr/lib/debug/usr/bin/oct-oscillator-strength.debug octopus-mpi.i386: W: no-documentation octopus.src: W: mixed-use-of-spaces-and-tabs (spaces: line 40, tab: line 1) octopus-devel.i386: W: no-documentation 5 packages and 0 specfiles checked; 13 errors, 20 warnings. Something has gone wrong here. %{_libdir}/* seems to be the culprit. - MUST: The package must meet the Packaging Guidelines . %post install-info %{_infodir}/octopus.info &> /dev/null %preun install-info --remove octopus &> /dev/null See https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Texinfo The tarball contains a number of bundled libraries that have separate upstreams. You should package them separately and modify (or work with upstream to modify) octopus to use the external, system-wide packages instead. - MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines . Some files are under GPLv2+ and some (libxc) are under LGPLv3+. There are many files without licensing information, so please ask upstream to fix that. See attached log (attachment #319179) from licensecheck for more details. external_libs/expokit is non-free and must be removed from distributed sources unless you can convince its authors to relicense it under a free license. external_libs/metis-4.0 is non-free. external_libs/qshep is non-free as well. - MUST: The License field in the package spec file must match the actual license. License: GPLv2+ Should be GPLv3+. IIUC LGPLv3+ libraries can only be linked in if GPLv2+ sources are "upgraded" to GPLv3. I'll re-check this, but I think I'm correct. - MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use md5sum for this task. If no upstream URL can be specified for this package, please see the Source URL Guidelines for how to deal with this. Source URL is bad: $ spectool -g octopus.spec --2008-10-01 23:47:15-- http://www.tddft.org/programs/octopus/download/octopus-3.0.1.tar.gz Resolving www.tddft.org... 193.137.208.200 Connecting to www.tddft.org|193.137.208.200|:80... connected. HTTP request sent, awaiting response... 404 Not Found 2008-10-01 23:47:16 ERROR 404: Not Found. SRPM source file doesn't match upstream: 54e00d2eb2af7fbd902876bef32b409e octopus-3.0.1.tar.gz e17887506f2596e1826d2d09bc75214f octopus-3.0.1.tar.gz.srpm - MUST: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. Apply common sense. >From configure output: checking for ATL_xerbla in -latlas... no Maybe add BuildRequires: atlas-devel? checking for netcdf... no configure: WARNING: Could not find netcdf library. *** Will compile without netcdf support BuildRequires: netcdf-devel seems not enough, you need to fix configure, too. - MUST: Each package must consistently use macros, as described in the macros section of Packaging Guidelines . %install rm -rf %{buildroot} cd single make install DESTDIR=%{buildroot} cd .. cd mpi make install DESTDIR=${RPM_BUILD_ROOT} cd .. %clean rm -rf ${RPM_BUILD_ROOT} Inconsistent usage, please fix. One last thing: there's a testsuite in the package. Please consider adding %check make check -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review