Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=437192 Dominik 'Rathann' Mierzejewski <rpm@xxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: simdock - |Review Request: simdock - |Fast and customizable |Fast and customizable |dockbar |dockbar --- Comment #2 from Dominik 'Rathann' Mierzejewski <rpm@xxxxxxxxxxxxxx> 2008-10-01 17:44:34 EDT --- Are you sponsored? I can't find your name in Fedora Account System. Some additional comments: Per https://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files You must add BuildRequires: desktop-file-utils and install the .desktop file using desktop-file-install. The desktop file itself should contain Icon=simdock not Icon=simdock.png Build fails on rawhide: error: %patch without corresponding "Patch:" tag Solution: use %patch0 It builds fine in mock after that, so BuildRequires (apart from the above) are fine. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review