Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=464424 Dominik 'Rathann' Mierzejewski <rpm@xxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #13 from Dominik 'Rathann' Mierzejewski <rpm@xxxxxxxxxxxxxx> 2008-10-01 17:25:39 EDT --- Some final nitpicking: rpmlint: gromacs-mpi-libs.x86_64: E: non-empty-%postun /sbin/ldconfig Please remove the following line # Clean buildroot because it is between %postun mpi-libs -p /sbin/ldconfig and %clean which makes rpmbuild treat it as part of the %postun scriptlet. BuildRequires: openmpi-devel FYI: Alternatives support in openmpi will probably be gone in next release (it's already gone from lam), so you might need something like this in the future: BuildRequires: environment-modules and . /etc/profile.d/modules.sh module load %{_libdir}/openmpi/*/openmpi.module before ./configure with mpi %package zsh Summary: Zsh completion for GROMACS It's not just completion now, is it? :) Same for %package csh. %package devel Requires: gromacs = %{version}-%{release} %package mpi-devel Requires: gromacs-mpi = %{version}-%{release} Do the -devel packages really require the binaries? Or would it be sufficient to require the -libs subpackages. export CFLAGS="%optflags -Wa,--noexecstack" Could this CFLAGS addition be limited only to files that need it? That'd require some Makefile.in patching, of course. However, none of the above are blockers, so feel free to fix them after the package is imported. Good work. APPROVED Based on this package and your reviews of other packages, I'm sponsoring you. Please request "packager" group membership in the Fedora Account System and I'll approve your request. Welcome aboard! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review