Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=455426 --- Comment #7 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2008-09-30 12:35:17 EDT --- For 0.8-3: * License - All codes with explicitly licensed are under LGPLv3 strict. Also, icons included in the tarball are under CC-BY-SA. So the license tag should be "LGPLv3 and CC-BY-SA". * Patch - What is this patch for? It seems after you apply this patch you modify what is changed by this patch by using sed again... I guess using sed from the beginning is better. * Requires - Are gstreamer-plugins-base, gstreamer-plugins-good _really_ needed? More verbosely, is gstreamer-java out of work when gstreamer-plugins-base or gstreamer-plugins-good are not installed? I guess what you mean here is "Conflicts: gstreamer-plugins-base < 0.10.19" or so. * rpmlint ------------------------------------------------------------- gstreamer-java.src: E: description-line-too-long An unofficial/alternative set of java bindings for the gstreamer multimedia framework. ------------------------------------------------------------- - One line in %description must contain less than 80 characters. ? About this line for swt.jar: ------------------------------------------------------------- $(find %{_libdir} -name swt*.jar 2>/dev/null|sort|head -1) ------------------------------------------------------------- - Can't this part be replaced by $(build-classpath swt)? * Documents - Please add the following to %doc (of main package) ------------------------------------------------------------- CHANGES COPYING* ------------------------------------------------------------- * %changelog - The last entry in %changelog does not coincide with current srpm EVR (Epoch-Version-Release). ! By the way as you say this srpm does not build on rawhide. Would you file a bug (perhaps against jna) so that we can keep track of this issue? dist-f10 build: http://koji.fedoraproject.org/koji/taskinfo?taskID=850032 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review