Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=462446 --- Comment #11 from GÃran Uddeborg <goeran@xxxxxxxxxxx> 2008-09-30 12:17:14 EDT --- > It seems to me that in /usr/share/ttf2pt1/scripts/, only > trans t1fdir forceiso x2gs > are needed, since others seems to be only used during build or > already in %_bindir. The scripts used only during the build can be removed. The documentation for convert and x2gs mainly talks about them with these names. It mentions that they also exist under a different name in the default path, but treats the short names as the main ones. I guess I've already invalidated the documentation somewhat by moving the README*, FONT* and similar files to defaultdocdir. The manual pages refers to these as /usr/share/ttf2pt1/README etc. But this feels a bit more invasive. Or is it part of packaging to actually rewrite the documentation for the package? > It would be better if convert looked for convert.cfg somewhere > else than in pwd. Maybe, maybe not. It describes what "convert" should do, and in that sense has some similarities with a Makefile. There may be several such files, each converting different sources. But in any case, I wouldn't change such a thing in the role of packager, would I? That seems like a discussion to have with upstreams if one want to change it. > convert.cfg.sample should certainly better be in %doc Same problem with documentation as I mentioned above, but ok. > t1asm is already in t1utils Good point. I'll remove it from this package and add a "requires" dependency instead. > Also which file is covered by the GPLv2+? The TeX scripts for CJK fonts. In /usr/share/doc/ttf2pt1-3.4.4/TeX in the current package. See the thread https://www.redhat.com/archives/fedora-legal-list/2008-September/msg00012.html for my questions about licensing. > Also forgot to say that the use fakeroot certainly deserves a comment. True. I'll add a comment in the SPEC file. I've made an intermediate update available: Spec URL: ftp://ftp.uddeborg.se/pub/ttf2pt1/ttf2pt1.spec SRPM URL: ftp://ftp.uddeborg.se/pub/ttf2pt1/ttf2pt1-3.4.4-5.src.rpm (The convert and x2gs scripts are still included, and I haven't touched how "convert" finds its configuration file. I'll wait for further comments on that before I do anything.) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review