Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=455211 Peter Lemenkov <lemenkov@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #11 from Peter Lemenkov <lemenkov@xxxxxxxxx> 2008-09-29 17:01:59 EDT --- REVIEW: + rpmlint is silent on every package. + The package is named according to the Package Naming Guidelines . + The spec file name matches the base package %{name}, in the format %{name}.spec. + The package meets the Packaging Guidelines. + The package must be licensed with a Fedora approved license and meet the Licensing Guidelines . + The License field in the package spec file matches the actual license. + The file, containing the text of the license(s) for the package is included in %doc. + The spec file is written in American English. + The spec file for the package is legible. + The sources used to build the package matches the upstream source [petro@Sulaco SOURCES]$ md5sum laconica-0.5.0.tar.gz* c427521f2df6ce6c7962e8da19d57850 laconica-0.5.0.tar.gz c427521f2df6ce6c7962e8da19d57850 laconica-0.5.0.tar.gz.orig [petro@Sulaco SOURCES]$ + The package successfully compiles and builds into binary rpms on at least one supported architecture (ppc). + No additional build dependencies. + No shared library files. + The package isn't designed to be relocatable. + The package owns all directories that it creates. + The package does not contain any duplicate files in the %files listing. + Permissions on files are set properly. + The package has a %clean section, which contains rm -rf $RPM_BUILD_ROOT. + The package consistently uses macros, as described in the macros section of Packaging Guidelines . + The package contains code, or permissable content. + No large documentation files. + All, the package includes as %doc, does not affect the runtime of the application. + No header files. + No static libraries. + No pkgconfig(.pc) files. + The package does NOT contain any .la libtool archives. + Not a GUI app. + The package does not own files or directories already owned by other packages. + At the beginning of %install, the package runs rm -rf $RPM_BUILD_ROOT. + All filenames in rpm package are valid UTF-8. Few remarks: * Please, remove the rest of %{docdir} stuff (see attached patch) * Consider adding additional "Provides: laconica" for those who wants to install it by simply typing "sudo yum install laconica". That's just my personal wish and not a blocker. And this package is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review