[Bug 464424] Review Request: GROMACS - a Molecular Dynamics package

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=464424





--- Comment #2 from Jussi Lehtola <jussi.lehtola@xxxxxx>  2008-09-28 17:00:54 EDT ---
Oh, I had just looked in the requests and old packages, I hadn't noticed that
you had tried making an RPM before.

I cleaned up the BuildRequires; it's true that they were a bit redundant.

Prelink is needed since I have to remove executable stacks from libraries.

I changed -share to -common as suggested.

As I wrote now in the spec file the configures are done in the %install phase,
since in order to get the {single,double}{,mpi} binaries you need to redo the
configure and install phase 4 times. The beginning of the %install phase erases
%buildroot.

rpmlint output at http://theory.physics.helsinki.fi/~jzlehtol/rpms/gromacs.lint

The zero-length makefile is the only "real" problem; maybe we need to find a
workaround. The makefile for compiling user-made analysis software is generated
on the fly by the build process. The other warnings are about missing
documentation (which is in gromacs-share) and about devel-files in non-devel
packages, which are runtime libraries needed anyway in the programs.


Also, you might want to have a look at

https://bugzilla.redhat.com/show_bug.cgi?id=464432

a package of Octopus which I also just made.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]