Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=464424 Dominik 'Rathann' Mierzejewski <rpm@xxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |rpm@xxxxxxxxxxxxxx --- Comment #1 from Dominik 'Rathann' Mierzejewski <rpm@xxxxxxxxxxxxxx> 2008-09-28 15:30:00 EDT --- Oh, nice to see someone pick up what I didn't finish. I see you haven't used my specfile (see bug 249831), but that's OK. A few comments after a cursory look: BuildRequires: fftw, fftw-devel, gsl, gsl-devel, libX11, libX11-devel, automake, autoconf, openmpi, openmpi-devel, libxml2, libxml2-devel, prelink I'd prefer it if you put each buildrequire in a separate line and sort them alphabetically. It makes it easier to read and it makes diffs smaller when you change BRs. And I think about half of these are redundant, so that leaves us with: BuildRequires: autoconf BuildRequires: automake BuildRequires: fftw-devel BuildRequires: gsl-devel BuildRequires: libX11-devel BuildRequires: libxml2-devel BuildRequires: openmpi-devel Why did you put prelink here? %package share Summary: GROMACS shared data and documentation I think that should be named -common, not -share, but it's a matter of preference. #BuildArch: noarch #BuildArch: %_target_cpu Please drop these. That feature of rpm is present only in rawhide and it hasn't been decided if we're going to allow using it, because koji can't handle it yet. aclocal autoheader automake autoconf Try replacing that with a simple autoreconf Also, all ./configure and make (but not make install) calls in %install should be moved to %build. Could you explain why you put them in %install? I'll write up a full review after you've addressed the above. Don't forget to post the output of rpmlint run on your packages. I can sponsor you, but you'll have to do at least two package reviews (apart from making this package pass my review, of course). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review