[Bug 463217] Review Request: gnuplot-py - Python interface to Gnuplot

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=463217


James Ralston <ralston@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ralston@xxxxxxxxx




--- Comment #1 from James Ralston <ralston@xxxxxxxxx>  2008-09-23 18:02:17 EDT ---
Your spec file is missing at least:

BuildRequires: numpy

The way you've elected to remove the shebang from various files updates the
timestamps on those files.  It is (arguably) better to use a method that
retains the original timestamps.  E.g.:

for F in demo.py utils.py __init__.py test.py funcutils.py; do
  %{__sed} -i.orig -e 1d ${F}
  touch -r ${F}.orig ${F}
  rm ${F}.orig
done

You should ask upstream to remove the shebangs from the files in question, and
note in the spec file that you have done so.  See:

https://fedoraproject.org/wiki/Packaging/Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]