Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459915 --- Comment #6 from Sylvain Beucler <beuc@xxxxxxxx> 2008-09-23 16:58:23 EDT --- (In reply to comment #5) > For 1.08.20080920-1: > > * Licensing > - Well, from texts about licensing in source tarball all the > contents in the tarball are free. > > However now the tag "License: zlib" (only) is no longer valid > as some more files are added as written in README-REPLACEMENTS.txt. OK, should be good now: License: zlib and CC-BY-SA and (GPLv3+ or Free Art or CC-BY-SA) and OAL and Public Domain and CC-BY and GPLv2+ > * Also adding files under licenses/ to %doc is necessary. Is it OK to add the "licenses/" directory directly? > * Macros > - Use macros for standard directories: > https://fedoraproject.org/wiki/Packaging/RPMMacros > /usr must be %{_prefix}. I missed that one. > * Timestamps > - As this package installs many files in the source tarball as they > are, keeping timestamps on those files is strongly recommended. > Please replace "cp -r" in Makefile to "cp -pr" or "cp -a". Fixed in GIT and applied as a patch to avoid a new 56M release. > * General rpmlint issue > --------------------------------------------------------------- > W: wrong-file-end-of-line-encoding > /usr/share/doc/freedink-data-1.08.20080920/README-REPLACEMENTS.txt > W: wrong-file-end-of-line-encoding > /usr/share/doc/freedink-data-1.08.20080920/README.txt > --------------------------------------------------------------- > - These files have CRLF line terminators, remove them > (sed -e 's|\r||' or dos2unix will do this). > > https://fedoraproject.org/wiki/PackageMaintainers/Common_Rpmlint_Issues#wrong-file-end-of-line-encoding OK, done. Here are the new files: http://www.freedink.org/snapshots/fedora-review/freedink-data.spec http://www.freedink.org/snapshots/fedora-review/freedink-data-1.08.20080920-1.fc8.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review