Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459915 --- Comment #5 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2008-09-22 14:52:37 EDT --- For 1.08.20080920-1: * Licensing - Well, from texts about licensing in source tarball all the contents in the tarball are free. However now the tag "License: zlib" (only) is no longer valid as some more files are added as written in README-REPLACEMENTS.txt. * Please check README.txt, README-REPLACEMENTS.txt and update License tag. Also please refer to the below. - About the kind of tags used on Fedora licensing: https://fedoraproject.org/wiki/Licensing - About how to write the tag of License for source tarball containing contents under different licenses: https://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License:_field * Also adding files under licenses/ to %doc is necessary. * Macros - Use macros for standard directories: https://fedoraproject.org/wiki/Packaging/RPMMacros /usr must be %{_prefix}. * Timestamps - As this package installs many files in the source tarball as they are, keeping timestamps on those files is strongly recommended. Please replace "cp -r" in Makefile to "cp -pr" or "cp -a". * General rpmlint issue --------------------------------------------------------------- W: wrong-file-end-of-line-encoding /usr/share/doc/freedink-data-1.08.20080920/README-REPLACEMENTS.txt W: wrong-file-end-of-line-encoding /usr/share/doc/freedink-data-1.08.20080920/README.txt --------------------------------------------------------------- - These files have CRLF line terminators, remove them (sed -e 's|\r||' or dos2unix will do this). https://fedoraproject.org/wiki/PackageMaintainers/Common_Rpmlint_Issues#wrong-file-end-of-line-encoding -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review