Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=463123 --- Comment #1 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2008-09-23 12:00:07 EDT --- For 0.5.3-1: * License - As far as I checked the source codes, the license tag should be "GPLv3+". * SourceURL - You may want to use %{name}, %{version} (especially %{version}) tags for SourceURL, as with these tags you probably won't have to change SourceURL when the version is upgraded. * BuildRequires * Perl module dependency - For perl module dependency, please don't write the rpm name directly but use virtual Provides modules names the rpm will provide (i.e. "BuildRequries: perl-XML-Parser" should be "BuildRequires: perl(XML::Parser)" : https://fedoraproject.org/wiki/Packaging/Perl#Perl_Requires_and_Provides ) * gnutls BR - You should use "BuildRequires: gnutls-devel >= 2" and "Requires: gnutls >= 2" is not needed. * Redundant BR - Some BRs are redundant. ! gtk2-devel, GConf2-devel, libglade2-devel - all required by libgnomeui-devel ! libgcrypt-devel - required by gnutls-devel * Compiler flags - build log shows Fedora specific compilations are not correctly passed. (You can check what compilar flags Fedora uses now by $ rpm --eval %optflags ) * Timestamps - Please consider to use ---------------------------------------------------------- make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" ---------------------------------------------------------- to keep timestamps on installed files as much as possible. This method usually works for Makefiles generated by recent autotools. * Desktop file - Category "Application;" is deprecated and should be removed (you can use --remove-category option). * Scriptlets - Requires(post) or so is missing. Please refer to https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#GConf * Documents - Usually the file "INSTALL" is for people who want to compile and install this package by themselves and is not needed for rpm users. - "BUGS" has zero size and there doesn't seem to be any reason to contain this file. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review