Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=462982 Jan ONDREJ <ondrejj@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ondrejj@xxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |ondrejj@xxxxxxxxxx Flag| |needinfo?(bruno.cornec@xxxx | |om) --- Comment #1 from Jan ONDREJ <ondrejj@xxxxxxxxxx> 2008-09-20 01:54:01 EDT --- Fix licence. Source code says: "either version 1, or (at your option) any later version.". According to FedoraLicenses, it must be GPL+, not GPLv2+. Fix "Source:" path. Your URL points to different URL like Source. I think your URL is OK, but you have to change Source to original path, not path to your local site. Fix BuildRoot, use any of these: http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag Your path is similar, but not same as described here. [ondrejj@builder result]$ rpmlint *.rpm 3 packages and 0 specfiles checked; 0 errors, 0 warnings. Builds well on i386, x86_64, f8, f9 and devel. Other personal suggestions: 01-debian-patches.all.gz does not look as an Fedora patch. Please, can you rename it and remove debian specific parts? I don't see more problems in this package. Fix described problems and I can approve this package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review