Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=449037 --- Comment #8 from Bruno Cornec <bruno.cornec@xxxxxx> 2008-09-19 18:59:33 EDT --- (In reply to comment #7) > (In reply to comment #6) > > > > xx - rpmlint is unclean on RPM > > > + [rishi@freebook x86_64]$ rpmlint afio-2.5-1.fc9.x86_64.rpm > > > afio.x86_64: W: spurious-executable-perm > > > /usr/share/doc/afio-2.5/script2/restore > Just chmod and remove the executable bits. Ok. Done. > > > + It might be a good idea to add a check stanza and run 'make regtest' and > > > 'make regtest2gb' in it. > > > It is possible, but it would be better to have them during the review itself, > if possible. :-) Indeed. I added them. > > > + According to > > > https://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps you > > > should use 'install -p'. > > > > I don't see exactly the point here. The Makefile provided doesn't use install. > > Yes, but you are using 'install -m ...' in the %install stanza. You should use > 'install -p -m ...' instead. Oops, sorry, missed that. Fixed now. > Please try to fix this because the packaged source tarball should match the > upstream tarball if there is no valid reason otherwise. Yep. Agreed. I fixed the tool in the mean time. New RPM available at ftp://ftp.mondorescue.org/test/fedora/9/afio-2.5-1.fc9.src.rpm and spec file at ftp://ftp.mondorescue.org/test/fedora/9/afio.spec Let me know if you think it's better now. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review