Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=460632 --- Comment #3 from Marek Mahut <mmahut@xxxxxxxxxx> 2008-08-29 10:42:44 EDT --- Thank you for initial review, (In reply to comment #1) > 0.) You may want to rename it > > I'm not sure if it is usable only with ircd-ratbox, or other ircds. In case it > cannot be used with other ircds, name ircd-ratbox-services is much more > appropriate. Would it make confusion? I'm not very big fun of delaying the original upstream name, if people find on the upstream page the product is called ratbox-services, it should be the same in Fedora (imo). It can be also used with hybrid ircd. > 1.) Do not depend on sendmail > > Requires: sendmail > > Replace with /usr/bin/sendmail or MTA or smtpdaemon, depending on ho do you use > sendmail. Done. > 2.) Explain non-obvious commands > > sed 's/-Werror//g' -i configure We remove usage of -Werror from flags. Once we have all ratbox packages in, I'll inform upstream including patches about it. Comment made in spec file > What's this? Comment it. > > Provides: perl(definetolength.pl) > > And this? Removed. > 3.) Fix owners/groups > > %config(noreplace) %{_sysconfdir}/logrotate.d/ratbox-services > > At least this is not to be owned by ircd. Change %defattr to use root by > default and override in %attr-s. You're right, done. > Furthermore, files that contain password should not be world-readable. Done. New SRPM is uploaded. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review